Opened 17 years ago

Closed 17 years ago

#5444 closed (fixed)

manipulators.py: Dynamically created classes should be types

Reported by: leosoto <leo.soto@…> Owned by: nobody
Component: Uncategorized Version: dev
Severity: Keywords: jython
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It's a obscure thing, but dynamic manipulator classes should be created using type, not types.ClassType, as it bases are new-style classes.

It may work on CPython, but Jython doesn't like this mismatch.

Attachments (1)

new-style-classes_are_types.patch​ (603 bytes ) - added by leosoto <leo.soto@…> 17 years ago.
patch

Download all attachments as: .zip

Change History (4)

by leosoto <leo.soto@…>, 17 years ago

Attachment: new-style-classes_are_types.patch​ added

patch

comment:1 by leosoto <leo.soto@…>, 17 years ago

Keywords: jython added

comment:2 by Malcolm Tredinnick, 17 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

(In [6277]) Fixed #5444 -- Changed manipulator class construction to use type(), rather than types.ClassType(). Helps with Jython compatibility. Patch from Leo Soto.

Note: See TracTickets for help on using tickets.
Back to Top