Opened 9 years ago

Closed 9 years ago

#5444 closed (fixed)

manipulators.py: Dynamically created classes should be types

Reported by: leosoto <leo.soto@…> Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords: jython
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It's a obscure thing, but dynamic manipulator classes should be created using type, not types.ClassType, as it bases are new-style classes.

It may work on CPython, but Jython doesn't like this mismatch.

Attachments (1)

new-style-classes_are_types.patch (603 bytes) - added by leosoto <leo.soto@…> 9 years ago.
patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by leosoto <leo.soto@…>

patch

comment:1 Changed 9 years ago by leosoto <leo.soto@…>

Keywords: jython added

comment:2 Changed 9 years ago by Malcolm Tredinnick

Triage Stage: UnreviewedReady for checkin

comment:3 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [6277]) Fixed #5444 -- Changed manipulator class construction to use type(), rather than types.ClassType(). Helps with Jython compatibility. Patch from Leo Soto.

Note: See TracTickets for help on using tickets.
Back to Top