Code

Opened 7 years ago

Closed 7 years ago

#5442 closed (fixed)

Workaround for jython isclass() bug

Reported by: leo.soto@… Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords: jython, sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

_doctest.py uses isclass(), which isn't 100% reliable on Jython, see http://sourceforge.net/tracker/index.php?func=detail&aid=1786009&group_id=12867&atid=112867.

Attachments (1)

jython_isclass_workaround.patch (727 bytes) - added by leo.soto@… 7 years ago.
Workaround for the bug until it's fixed on jython

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by leo.soto@…

Workaround for the bug until it's fixed on jython

comment:1 Changed 7 years ago by anonymous

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by Fredrik Lundh <fredrik@…>

  • Triage Stage changed from Unreviewed to Ready for checkin

I would have put the "patch_isclass" definition inside the if-statement (no need to add stuff to the module namespace on other platforms), but since this is test code (right?), that doesn't really matter that much.

comment:3 Changed 7 years ago by Fredrik Lundh <fredrik@…>

  • Keywords jython, sprintsept14 added; jython removed

comment:4 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [6194]) Fixed #5442 -- Added Jython workaround in django.test._doctest. Thanks, leo.soto@…

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.