Opened 8 years ago

Closed 8 years ago

#5431 closed (fixed)

Argentinean localflavor

Reported by: ramiro Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords: aArgentina localflavor
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Find attached the patch that implemements a widget and some field for Argentina-specific information, it included test cases.

Note: I can't get Mercurial to represent the empty django/contrib/localflavor/ar/__init__.py file on the patch it generates, so if this get commited, the file should be created manually, sorry for the burden :(

Attachments (2)

argentinean_localflavor_r6139.diff (14.9 KB) - added by ramiro 8 years ago.
argentinean_localflavor_r6139-2.diff (14.9 KB) - added by ramiro 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by ramiro

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 follow-up: Changed 8 years ago by mtredinnick

Line 112 of the patch can't be correct. It's referencing a variable that doesn't exist. Do you mean cuit[:-1] there?

comment:3 in reply to: ↑ 2 Changed 8 years ago by ramiro

  • Keywords aArgentina added; argentina removed

Replying to mtredinnick:

Line 112 of the patch can't be correct. It's referencing a variable that doesn't exist. Do you mean cuit[:-1] there?

You are completely right, sorry. New version of the patch attached with that fix.

/me installs pychecker.

Changed 8 years ago by ramiro

comment:4 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6145]) Fixed #5431 -- Added Argentinean localflavor. Thanks, Ramiro Morales.

Note: See TracTickets for help on using tickets.
Back to Top