Opened 9 years ago

Closed 9 years ago

#5394 closed (fixed)

REDIRECT_FIELD_NAME should be configurable

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: David Reynolds
Component: Contrib apps Version: master
Severity: Keywords: authorization, redirection, sprintsept14
Cc: david@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think that it should be possible to set REDIRECT_FIELD_NAME in settings.py. For example it can be useful if I want to have url in another language than English. It is changed by the attached patch.

Attachments (5)

configurable-redirect-field-name.diff (3.8 KB) - added by Petr Marhoun <petr.marhoun@…> 9 years ago.
configurable-redirect-field-name-2.diff (3.5 KB) - added by David Reynolds 9 years ago.
Fixing as per Adrian's suggestion
5394-docs.diff (721 bytes) - added by Antti Kaihola 9 years ago.
documentation for the patch
authentication-docs.diff (1.3 KB) - added by David Reynolds 9 years ago.
update authentication docs
redirect_to_fieldaddition.diff (7.8 KB) - added by David Reynolds 9 years ago.
All encompassing patch

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by Petr Marhoun <petr.marhoun@…>

comment:1 Changed 9 years ago by Simon G. <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 9 years ago by Adrian Holovaty

Needs documentation: set
Patch needs improvement: set
Triage Stage: Design decision neededAccepted

I agree that it should be configurable, but this is not "heavy" enough to merit a new setting. Instead, how about making the relevant auth views and decorators accept an optional redirect_field argument? Marking as "patch needs improvement" for that reason.

comment:3 Changed 9 years ago by David Reynolds

Owner: changed from nobody to David Reynolds

Changed 9 years ago by David Reynolds

Fixing as per Adrian's suggestion

comment:4 Changed 9 years ago by David Reynolds

Patch needs improvement: unset

comment:5 Changed 9 years ago by Antti Kaihola

Can this now be removed from SprintIdeas?

Changed 9 years ago by Antti Kaihola

Attachment: 5394-docs.diff added

documentation for the patch

comment:6 Changed 9 years ago by David Reynolds

Cc: david@… added

This change to the docs only reflects the original, bad patch, not my updated patch.

I'll look at the doing the docs now.

Changed 9 years ago by David Reynolds

Attachment: authentication-docs.diff added

update authentication docs

comment:7 Changed 9 years ago by David Reynolds

Needs documentation: unset

Changed 9 years ago by David Reynolds

All encompassing patch

comment:8 Changed 9 years ago by David Reynolds

Resolution: fixed
Status: newclosed

(forgot to mention effbot on irc helped massively with last patch)

comment:9 Changed 9 years ago by David Reynolds

Keywords: sprintsept14 added
Resolution: fixed
Status: closedreopened

comment:10 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: reopenedclosed

(In [6206]) Fixed #5394 -- REDIRECT_FIELD_NAME is now configurable. Thanks, Petr Marhoun, DavidReynolds and effbot

Note: See TracTickets for help on using tickets.
Back to Top