Code

Opened 7 years ago

Closed 7 years ago

#5394 closed (fixed)

REDIRECT_FIELD_NAME should be configurable

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: DavidReynolds
Component: Contrib apps Version: master
Severity: Keywords: authorization, redirection, sprintsept14
Cc: david@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think that it should be possible to set REDIRECT_FIELD_NAME in settings.py. For example it can be useful if I want to have url in another language than English. It is changed by the attached patch.

Attachments (5)

configurable-redirect-field-name.diff (3.8 KB) - added by Petr Marhoun <petr.marhoun@…> 7 years ago.
configurable-redirect-field-name-2.diff (3.5 KB) - added by DavidReynolds 7 years ago.
Fixing as per Adrian's suggestion
5394-docs.diff (721 bytes) - added by akaihola 7 years ago.
documentation for the patch
authentication-docs.diff (1.3 KB) - added by DavidReynolds 7 years ago.
update authentication docs
redirect_to_fieldaddition.diff (7.8 KB) - added by DavidReynolds 7 years ago.
All encompassing patch

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by Petr Marhoun <petr.marhoun@…>

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 7 years ago by adrian

  • Needs documentation set
  • Patch needs improvement set
  • Triage Stage changed from Design decision needed to Accepted

I agree that it should be configurable, but this is not "heavy" enough to merit a new setting. Instead, how about making the relevant auth views and decorators accept an optional redirect_field argument? Marking as "patch needs improvement" for that reason.

comment:3 Changed 7 years ago by DavidReynolds

  • Owner changed from nobody to DavidReynolds

Changed 7 years ago by DavidReynolds

Fixing as per Adrian's suggestion

comment:4 Changed 7 years ago by DavidReynolds

  • Patch needs improvement unset

comment:5 Changed 7 years ago by akaihola

Can this now be removed from SprintIdeas?

Changed 7 years ago by akaihola

documentation for the patch

comment:6 Changed 7 years ago by DavidReynolds

  • Cc david@… added

This change to the docs only reflects the original, bad patch, not my updated patch.

I'll look at the doing the docs now.

Changed 7 years ago by DavidReynolds

update authentication docs

comment:7 Changed 7 years ago by DavidReynolds

  • Needs documentation unset

Changed 7 years ago by DavidReynolds

All encompassing patch

comment:8 Changed 7 years ago by DavidReynolds

  • Resolution set to fixed
  • Status changed from new to closed

(forgot to mention effbot on irc helped massively with last patch)

comment:9 Changed 7 years ago by DavidReynolds

  • Keywords redirection, sprintsept14 added; redirection removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:10 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6206]) Fixed #5394 -- REDIRECT_FIELD_NAME is now configurable. Thanks, Petr Marhoun, DavidReynolds and effbot

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.