[newforms-admin] - validation is broken for sites with more than one inline formsets

[Petr Marhoun <petr.marhoun@…>]

Validation of inline formsets is done with this code:

def all_valid(formsets):
    """Returns true if every formset in formsets is valid."""
    valid = True
    for formset in formsets:
        if not formset.is_valid():
            return False

But method formset.is_valid has side-effect - it calls formset.clean_all and method clean_all resets all unused inline formset. But if first formset is invalid, forms in the second formset aren't reset.

This code works (attached patch changes it):

def all_valid(formsets):
    """Returns true if every formset in formsets is valid."""
    valid = True
    for formset in formsets:
        if not formset.is_valid():
            valid = False
    return valid

[jkocherhans]

(In [6104]) newforms-admin: Fixed #5388. Validation broken for models with > 1 inline formset.