Opened 9 years ago

Closed 9 years ago

#5376 closed (fixed)

Add --addrport option to testserver command

Reported by: Todd O'Bryan Owned by: Todd O'Bryan
Component: Core (Management commands) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Because the testserver command takes fixtures as arguments, you can't currently set the IP address or port that it should use when it runs the server.

This ticket adds the option --addrport to testserver and just passes it to the runserver command.

Attachments (2)

testserver-addrport.patch (3.1 KB) - added by Todd O'Bryan 9 years ago.
docs.patch (811 bytes) - added by Todd O'Bryan 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by Todd O'Bryan

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Todd O'Bryan
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 9 years ago by Adrian Holovaty

Patch looks good, other than the fact that it should be made relative to your trunk directory -- i.e., the diff shouldn't contain "/home/tobryan1/workspace". Also, could you include a patch to docs/django-admin.txt? Here's all you need to know about documentation changes: http://www.djangoproject.com/documentation/contributing/#documentation-style

comment:3 Changed 9 years ago by Adrian Holovaty

Triage Stage: UnreviewedAccepted

comment:4 Changed 9 years ago by Adrian Holovaty

Needs documentation: set

Changed 9 years ago by Todd O'Bryan

Attachment: testserver-addrport.patch added

comment:5 Changed 9 years ago by Todd O'Bryan

Needs documentation: unset

comment:6 Changed 9 years ago by Simon G. <dev@…>

Triage Stage: AcceptedReady for checkin

comment:7 Changed 9 years ago by Adrian Holovaty

I'm working on reviewing this and checking it in.

comment:8 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: assignedclosed

(In [6204]) Fixed #5376 -- Added --addrport option to the 'testserver' command. Thanks, toddobryan

Changed 9 years ago by Todd O'Bryan

Attachment: docs.patch added

comment:9 Changed 9 years ago by Todd O'Bryan

Resolution: fixed
Status: closedreopened

There are two typos that are misleading. They're fixed in docs.patch.

comment:10 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: reopenedclosed

(In [6363]) FIxed #5376 -- Fixed typo in testserver docs

Note: See TracTickets for help on using tickets.
Back to Top