Code

Opened 7 years ago

Closed 7 years ago

#5376 closed (fixed)

Add --addrport option to testserver command

Reported by: toddobryan Owned by: toddobryan
Component: Core (Management commands) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Because the testserver command takes fixtures as arguments, you can't currently set the IP address or port that it should use when it runs the server.

This ticket adds the option --addrport to testserver and just passes it to the runserver command.

Attachments (2)

testserver-addrport.patch (3.1 KB) - added by toddobryan 7 years ago.
docs.patch (811 bytes) - added by toddobryan 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by toddobryan

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to toddobryan
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 7 years ago by adrian

Patch looks good, other than the fact that it should be made relative to your trunk directory -- i.e., the diff shouldn't contain "/home/tobryan1/workspace". Also, could you include a patch to docs/django-admin.txt? Here's all you need to know about documentation changes: http://www.djangoproject.com/documentation/contributing/#documentation-style

comment:3 Changed 7 years ago by adrian

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 7 years ago by adrian

  • Needs documentation set

Changed 7 years ago by toddobryan

comment:5 Changed 7 years ago by toddobryan

  • Needs documentation unset

comment:6 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 7 years ago by adrian

I'm working on reviewing this and checking it in.

comment:8 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6204]) Fixed #5376 -- Added --addrport option to the 'testserver' command. Thanks, toddobryan

Changed 7 years ago by toddobryan

comment:9 Changed 7 years ago by toddobryan

  • Resolution fixed deleted
  • Status changed from closed to reopened

There are two typos that are misleading. They're fixed in docs.patch.

comment:10 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6363]) FIxed #5376 -- Fixed typo in testserver docs

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.