Code

Opened 7 years ago

Last modified 2 years ago

#5349 new Cleanup/optimization

Shouldn't the item_enclosure_url automatically prefixed with the current site?

Reported by: anonymous Owned by: nobody
Component: contrib.syndication Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I'd recommend to add a call to add_domain() to the enclosure URL because other URLs are also automatically extended with the site's URL. I've included the patch.

Attachments (1)

3.diff (756 bytes) - added by anonymous 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by anonymous

comment:1 Changed 7 years ago by ubernostrum

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Isn't there a very strong possibility that the file included in the enclosure is not on the same server/domain as the Django application serving the feed?

comment:2 Changed 7 years ago by anonymous

If the file is on a different server/domain, then use an absolute URL. Otherwise, use a relative path and let add_domain add the current site's domain. It should be the same behavior as with the other URLs, IMHO.

comment:3 Changed 7 years ago by Simon G. <dev@…>

  • Has patch set
  • Triage Stage changed from Unreviewed to Design decision needed

comment:4 Changed 4 years ago by russellm

  • Triage Stage changed from Design decision needed to Accepted

Accepted, although the implementation needs to be aware of base paths in Atom, etc.

comment:5 Changed 3 years ago by gabrielhurley

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:6 Changed 3 years ago by julien

  • Easy pickings unset
  • Needs documentation set
  • Needs tests set

comment:7 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new
The owner will be changed from nobody to anonymous. Next status will be 'assigned'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.