Opened 17 years ago
Last modified 12 years ago
#5349 new Cleanup/optimization
Shouldn't the item_enclosure_url automatically prefixed with the current site?
| Reported by: | anonymous | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I'd recommend to add a call to add_domain() to the enclosure URL because other URLs are also automatically extended with the site's URL. I've included the patch.
Attachments (1)
Change History (8)
by , 17 years ago
comment:1 by , 17 years ago
comment:2 by , 17 years ago
If the file is on a different server/domain, then use an absolute URL. Otherwise, use a relative path and let add_domain add the current site's domain. It should be the same behavior as with the other URLs, IMHO.
comment:3 by , 17 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Design decision needed |
comment:4 by , 14 years ago
| Triage Stage: | Design decision needed → Accepted |
|---|
Accepted, although the implementation needs to be aware of base paths in Atom, etc.
comment:5 by , 13 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Cleanup/optimization |
comment:6 by , 13 years ago
| Easy pickings: | unset |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
Note:
See TracTickets
for help on using tickets.
Isn't there a very strong possibility that the file included in the enclosure is not on the same server/domain as the Django application serving the feed?