Opened 13 years ago

Last modified 8 years ago

#5349 new Cleanup/optimization

Shouldn't the item_enclosure_url automatically prefixed with the current site?

Reported by: anonymous Owned by: nobody
Component: contrib.syndication Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no


I'd recommend to add a call to add_domain() to the enclosure URL because other URLs are also automatically extended with the site's URL. I've included the patch.

Attachments (1)

3.diff (756 bytes) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by anonymous

Attachment: 3.diff added

comment:1 Changed 13 years ago by James Bennett

Isn't there a very strong possibility that the file included in the enclosure is not on the same server/domain as the Django application serving the feed?

comment:2 Changed 13 years ago by anonymous

If the file is on a different server/domain, then use an absolute URL. Otherwise, use a relative path and let add_domain add the current site's domain. It should be the same behavior as with the other URLs, IMHO.

comment:3 Changed 13 years ago by Simon G. <dev@…>

Has patch: set
Triage Stage: UnreviewedDesign decision needed

comment:4 Changed 10 years ago by Russell Keith-Magee

Triage Stage: Design decision neededAccepted

Accepted, although the implementation needs to be aware of base paths in Atom, etc.

comment:5 Changed 9 years ago by Gabriel Hurley

Severity: Normal
Type: Cleanup/optimization

comment:6 Changed 9 years ago by Julien Phalip

Easy pickings: unset
Needs documentation: set
Needs tests: set

comment:7 Changed 8 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

Note: See TracTickets for help on using tickets.
Back to Top