Opened 7 years ago

Closed 7 years ago

#5340 closed (fixed)

request for new link in docs

Reported by: rogerpack2005@… Owned by: justinlilly@…
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think
that http://www.djangoproject.com/documentation/templates/ should link to
http://www.djangoproject.com/documentation/templates_python/ at the bottom--maybe a link like "click here to program your own" or what not. Thanks! Django rox!

Attachments (3)

templates.txt (45.2 KB) - added by justinlilly@… 7 years ago.
Proposed patch to fix the escaping issue causing the bug
template.diff (177 bytes) - added by Justin Lilly <justinlilly@…> 7 years ago.
This should be the .diff file required.
template.2.diff (593 bytes) - added by Justin Lilly <justinlilly@…> 7 years ago.
This should be a viewable version of the previous patch.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [6070]) Fixed #5340 -- Linked docs/templates.txt to docs/templates_python.txt

comment:2 Changed 7 years ago by john.scott.atlakson@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Resolution fixed deleted
  • Status changed from closed to reopened

This patch results in an error...see http://www.djangoproject.com/documentation/templates/#id3
I don't know much about reStructured Text formatting but my guess that the colon within the link name might be confusing the parser. The line in question:

.. _The Django template language: For Python programmers: ../templates_python/

Changed 7 years ago by justinlilly@…

Proposed patch to fix the escaping issue causing the bug

comment:3 Changed 7 years ago by justinlilly@…

  • Patch needs improvement unset
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Triage Stage changed from Unreviewed to Ready for checkin

Should be fixed. Just needed an escaping backslash on the link. I've tested this with http://www.hosting4u.cz/jbar/rest/rest.html which seemed to do okay.

comment:4 Changed 7 years ago by russellm

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Ready for checkin to Accepted

This isn't ready for checkin - it needs to be submitted as a patch, not as a replacement file. Also, please don't mark the ticket as fixed - that is done automatically by SVN during the checkin process.

comment:5 Changed 7 years ago by justinlilly@…

  • Has patch set
  • Owner changed from jacob to justinlilly@…
  • Status changed from reopened to new

Terribly sorry for that. Well then, I suppose this is me submitting the item as "Has Patch", accepting it personally. Sorry, this is my first ticket so here goes again, eh?

comment:6 Changed 7 years ago by russellm

Perhaps I wasn't clear - the file you upload needs to be a patch - i.e., a diff file, not a complete replacement for the original.

Changed 7 years ago by Justin Lilly <justinlilly@…>

This should be the .diff file required.

Changed 7 years ago by Justin Lilly <justinlilly@…>

This should be a viewable version of the previous patch.

comment:7 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6184]) Fixed #5340 -- Fixed a broken link. Thanks, Justin Lilly.

Note: See TracTickets for help on using tickets.
Back to Top