add an assertContext method to Django's TestCase

[Gary Wilson]

A method for testing that a context used for rendering a response contains a specified value. To be used as:

self.assertContext(response, variable_name, value)

[Gary Wilson]

hmmm, not sure why the diff doesn't show in the Trac viewer.

[Johan Bergström]

You probably want to name the file "5333.patch" (i had similar issues earlier)

[Russell Keith-Magee]

My hesitation here (and the reason I didn't include a 'context assert' in the first place) is that assertContext does an Equals test, but doesn't provide a way to do any other assertion - NotEquals, True, False, LessThan, etc. We could get around this by adding assertContextEquals, assertContextNotEquals, and so on, but that is really just duplicating the underlying assertion API. This is certainly possible, but I'm not convinced it is the best approach.

An alternate approach would be to provide a utility function to get the value of a context variable from the list of contexts in a response. This would allow the use of all the standard assert methods. However, I'm not entirely sure where such a utility function should go. Putting it on the TestCase itself rubs me the wrong way.

I'm open to suggestions (or to comments that I'm just round-the-twist crazy).

For future reference, some feedback on the patch itself:

1. The test cases should check the multiple-context case, not just the single-context case
2. If possible, it would also be good to provide the 'trailing space' parts of the patch separately to the new assertion+tests. As is, there is a lot of noise in the patch from all the whitespace stripping changes, which is an impediment to the immediate understanding of the patch.

[Malcolm Tredinnick]

I prefer the approach Russell's talking about in comment 3. A nice way to check the value that would be used if I rendered "foo" from the context that understands context are sometimes like an onion (does that mean they're also like an ogre?).

I don't think such a function should live on TestCase, since that would hurt doctests. It has no class dependencies, so just make it a utility function. A standalone function that accepts a context and a variable name would seem to do the trick.

[Julien Phalip]

Since [10084] it is possible to easily access/control any variable in the response's context, so I presume this assertContext method is not really needed anymore. Shall this ticket be closed?

[Russell Keith-Magee]

Agreed. This one is essentially resolved.