URLField should add http:// if no scheme given

[Chris Beaven]

The usual scheme for a URLField is http://. You're average user will often not enter the scheme of their URL so the clean method should just prepend 'http://' if no scheme was given.

[Chris Beaven]

Makes sense to me, but I'll pass it past the core developers.

[Chris Beaven]

with tests

[Simon G. <dev@…>]

Ready to go.

[Russell Keith-Magee]

(In [6173]) Fixed #5331 -- Modified newforms URLField to prepend ​http:// if no protocol is specified by the user. Thanks, SmileyChris?.

[Adam Alton]

django.db.models.URLField doesn't have a custom 'formfield' method, and so by default it uses django.forms.CharField as its form field. And so django.forms.URLField never even gets used, so the patch submitted above is currently not having any effect (Django 1.3 alpha).

It needs a 'formfield' method adding to django.db.models.URLField...

#django/db/models/fields/__init__.py
class URLField:
    #snip
    def formfield(self, **kwargs):
        if 'form_class' not in kwargs:
            kwargs['form_class'] = forms.URLField
        return super(URLField, self).formfield(**kwargs)

[Russell Keith-Magee]

@adamalton -- I don't know what code you're looking at, but URLField *does* have a custom formfield method, there is a unit test validating that http prefixing works as intended, and a quick test verifies that the field is working as intended.