Opened 17 years ago
Closed 17 years ago
#5328 closed (wontfix)
Small ChoiceField.clean() fix
| Reported by: | Ramiro Morales | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | choicefield clean newforms empty EMPTY_VALUES | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
While reviewing #5327 I spotted a slightly sub-optimal code snippet in the aforementioned method. The aattached patch fixes it.
Attachments (1)
Change History (2)
by , 17 years ago
| Attachment: | newforms-choice-field-clean-r6040.diff added |
|---|
comment:1 by , 17 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
But this changes the logic of the clean function slightly -
valuemay be inEMPTY_VALUESafter it has been parsed bysmart_unicode