Opened 18 years ago

Closed 18 years ago

#5328 closed (wontfix)

Small ChoiceField.clean() fix

Reported by: Ramiro Morales Owned by: Adrian Holovaty
Component: Forms Version: dev
Severity: Keywords: choicefield clean newforms empty EMPTY_VALUES
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

While reviewing #5327 I spotted a slightly sub-optimal code snippet in the aforementioned method. The aattached patch fixes it.

Change History (2)

by Ramiro Morales, 18 years ago

Attachment: newforms-choice-field-clean-r6040.diff​ added

comment:1 by Chris Beaven, 18 years ago

Resolution: → wontfix
Status: new → closed

But this changes the logic of the clean function slightly - value may be in EMPTY_VALUES after it has been parsed by smart_unicode

Note: See TracTickets for help on using tickets.
Back to Top