Opened 8 years ago

Closed 8 years ago

#5328 closed (wontfix)

Small ChoiceField.clean() fix

Reported by: Ramiro Morales Owned by: adrian
Component: Forms Version: master
Severity: Keywords: choicefield clean newforms empty EMPTY_VALUES
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

While reviewing #5327 I spotted a slightly sub-optimal code snippet in the aforementioned method. The aattached patch fixes it.

Attachments (1)

newforms-choice-field-clean-r6040.diff (625 bytes) - added by Ramiro Morales 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by Ramiro Morales

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

But this changes the logic of the clean function slightly - value may be in EMPTY_VALUES after it has been parsed by smart_unicode

Note: See TracTickets for help on using tickets.
Back to Top