Opened 9 years ago

Closed 9 years ago

#5251 closed (fixed)

[newforms-admin] "Show in Web" links not working

Reported by: Florian Apolloner Owned by: Florian Apolloner
Component: contrib.admin Version: newforms-admin
Severity: Keywords: newforms-admin reverse sprintsept14
Cc: django@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The "Show in Web" Links on the change pages of the django admin are not working as admin/r/10/1 (just an example) returns "app u'r', model 10 (or something like it ;)) not found"...
This patch moves the checking to contrib/admin/sites to prevent this special url from getting displayed as model_page which obviously fails...

Attachments (2)

show_in_web-6000.diff (1.5 KB) - added by Florian Apolloner 9 years ago.
show_in_web.diff (677 bytes) - added by Florian Apolloner 9 years ago.
Shorter and better patch :)

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Florian Apolloner

Attachment: show_in_web-6000.diff added

comment:1 Changed 9 years ago by Simon G. <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: [newforms-admin][patch] "Show in Web" links not working[newforms-admin] "Show in Web" links not working
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Jacob

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

The special-casing in this patch isn't right. I think it can be fixed just be reordering the admin urlconf instead of this weird dispatch thing.

Changed 9 years ago by Florian Apolloner

Attachment: show_in_web.diff added

Shorter and better patch :)

comment:3 Changed 9 years ago by Florian Apolloner

Patch needs improvement: unset

comment:4 Changed 9 years ago by Florian Apolloner

I don't think it can be moved, as admin.site.root tries to call model_page, but my new patch is better :)

comment:5 Changed 9 years ago by Florian Apolloner

Owner: changed from nobody to Florian Apolloner
Status: newassigned

comment:6 Changed 9 years ago by anonymous

Keywords: sprintsept14 added; /admin/r/ removed

comment:7 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: assignedclosed

(In [6207]) newforms-admin: Fixed #5251 -- 'Show in Web' links now work properly again. Thanks, Florian Apolloner

Note: See TracTickets for help on using tickets.
Back to Top