Code

Opened 7 years ago

Closed 7 years ago

#5200 closed (fixed)

Polish PL Localflavor

Reported by: Slawek Mikula <slawek(dot)mikula<at>gmail[dot]com> Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords: localflavor polish
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Polish fields for localflavor module:

  • Postal Code check field
  • NIP (Polish tax number) field check
  • PESEL (identification number) field check
  • Voivodeship (wojewodztwa) select field
  • Administrative units (powiaty) select field

Administrative units are just with plain polish names.
I don't know if everyone has even a proper english name.

Attachments (3)

pl-localflavor-0.2.diff (42.2 KB) - added by Slawek Mikula <slawek dot mikula at gmail dot com> 7 years ago.
Implementation + regression tests patch
pl-localflavor-0.3.diff (4.9 KB) - added by Slawek Mikula <slawek.mikula@…> 7 years ago.
Added NIP checksum calculation, added REGON field, updated regression tests
pl-localflavor-0.3-r6397.txt (5.0 KB) - added by Slawek Mikula <slawek.mikula@…> 7 years ago.
New version of patch for test code refactoring (rev 6397)

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Slawek Mikula <slawek dot mikula at gmail dot com>

Implementation + regression tests patch

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

Excellent patch! Aside from a few whitespace changes to conform to the coding guidelines and a couple of tiny English changes, I didn't have to change anything.

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5936]) Fixed #5200 -- Added Polish localflavor. Thanks, Slawek Mikula.

Changed 7 years ago by Slawek Mikula <slawek.mikula@…>

Added NIP checksum calculation, added REGON field, updated regression tests

comment:4 Changed 7 years ago by Slawek Mikula <slawek.mikula@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Ready for checkin to Unreviewed

Added new patch (0.3) for

  • NIP field checksum calculation
  • new field REGON (with checksum calculation)
  • updated regression tests

comment:5 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Ready for checkin

Changed 7 years ago by Slawek Mikula <slawek.mikula@…>

New version of patch for test code refactoring (rev 6397)

comment:6 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6556]) Fixed #5200 -- Added some more functionality to the Polish localflavor. Thanks,
Slawek Mikula.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.