get_FIELD_url should return a valid URL with spaces escaped

[Esaj]

Some of my RSS feeds aren't validating because calling get_FIELD_url for an ImageField isn't escaping spaces in the filename.

A simple patch is attached which uses urllib.quote to fix this problem.

[Esaj]

Escape spaces in generated URL using urllib.quote

[Esaj]

Better patch; the previous one erroneously escapes MEDIA_URL

[Malcolm Tredinnick]

Using urllib.urlquote is incorrect here because the value could contain non-ASCII characters. Should be using django.utils.http.urlquote instead.

[Esaj]

Use django.util.http.urlquote for unicode safety

[Malcolm Tredinnick]

This isn't ready to commit yet. Firstly, because the existing tests fail, which is a bit of a showstopper (in this case, the failing test is probably wrong, but it still needs to be fixed at the same time). Secondly because it doesn't have any tests of its own. And, most importantly, because it causes some problems with serialisation -- things don't round-trip cleanly.

The last point is almost certainly a problem in the serialization framework, but it needs to be fixed first or at the same time. Moving back to accepted until I (or somebody else, preferably) can look at the issues.

[Claude Paroz]

Test that issue is solved

[Claude Paroz]

I guess this issue is solved nowadays. I've just added the test for the space char in the corresponding file_storage test.

[Aymeric Augustin]

get_FIELD_url doesn't exist anymore. Now it's just an url attribute on the field and the problem appears to be fixed. I'll commit the test.

[Aymeric Augustin]

In [17361]:

Tested that spaces are properly escaped in files URLs. Refs #5160.