Code

Opened 7 years ago

Closed 7 years ago

#5123 closed (fixed)

ImageField.formfield does not pass arguments correctly

Reported by: Collin Anderson <cmawebsite@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords: ImageField formfield
Cc: cmawebsite@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

formfield method of ImageField database field does not pass arguments correctly. It replaces instead of updating.

Attachments (1)

5833 ImageField formfield.patch (442 bytes) - added by Collin Anderson <cmawebsite@…> 7 years ago.
This adds the missing line that is in the other formfield methods of most of the other fields.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Collin Anderson <cmawebsite@…>

This adds the missing line that is in the other formfield methods of most of the other fields.

comment:1 Changed 7 years ago by Marco Bonetti <mbonetti@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I've had exactly the same problem as Collin (i.e. not being able to properly subclass ImageField because formfield() doesn't add to defaults) and came up with exactly the same solution. I therefore think his patch should be accepted and merged in.

comment:2 Changed 7 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 7 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [6154]) Fixed #5123 -- Fixed ImageField to pass along keyword arguments in its formfield method.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.