Opened 17 years ago

Closed 17 years ago

#5123 closed (fixed)

ImageField.formfield does not pass arguments correctly

Reported by: Collin Anderson <cmawebsite@…> Owned by: nobody
Component: Forms Version: dev
Severity: Keywords: ImageField formfield
Cc: cmawebsite@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

formfield method of ImageField database field does not pass arguments correctly. It replaces instead of updating.

Attachments (1)

5833 ImageField formfield.patch​ (442 bytes ) - added by Collin Anderson <cmawebsite@…> 17 years ago.
This adds the missing line that is in the other formfield methods of most of the other fields.

Download all attachments as: .zip

Change History (4)

by Collin Anderson <cmawebsite@…>, 17 years ago

Attachment: 5833 ImageField formfield.patch​ added

This adds the missing line that is in the other formfield methods of most of the other fields.

comment:1 by Marco Bonetti <mbonetti@…>, 17 years ago

I've had exactly the same problem as Collin (i.e. not being able to properly subclass ImageField because formfield() doesn't add to defaults) and came up with exactly the same solution. I therefore think his patch should be accepted and merged in.

comment:2 by Chris Beaven, 17 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Gary Wilson, 17 years ago

Resolution: → fixed
Status: new → closed

(In [6154]) Fixed #5123 -- Fixed ImageField to pass along keyword arguments in its formfield method.

Note: See TracTickets for help on using tickets.
Back to Top