Opened 8 years ago

Closed 8 years ago

#5109 closed (fixed)

signals.got_request_exception send Request Object

Reported by: Collin Anderson <cmawebsite@…> Owned by: nobody
Component: HTTP handling Version: master
Severity: Keywords: got_request_exception
Cc: cmawebsite@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


It would be nice if signals.got_request_exception passed request as an argument, especially for logging.

Attachments (1)

5109 error signal request argument.patch (792 bytes) - added by Collin Anderson <cmawebsite@…> 8 years ago.
patch against r5830 that adds this

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Collin Anderson <cmawebsite@…>

patch against r5830 that adds this

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Sounds like a good idea.

comment:2 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6292]) Fixed #5109 -- Pass the request object to any exception signal handler. Thanks, Collin Anderson.

This is fully backwards compatible, despite the addition of an extra argument.

Note: See TracTickets for help on using tickets.
Back to Top