Code

Opened 7 years ago

Closed 7 years ago

#5087 closed (fixed)

Error filtering on TextField when using Oracle backend

Reported by: ian.g.kelly@… Owned by: adrian
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Filtering on a TextField with the Oracle backend raises an error, because Oracle LOBs can't be compared directly inside a WHERE clause. This is especially problematic for the Admin interface, which uses a TextField foreign key in the history table. See the comments in #4186 for an example of this, but I'm opening a new ticket because this patch doesn't address the original bug of that ticket.

Attachments (2)

oracle_textfield_lookup.diff (5.1 KB) - added by ian.g.kelly@… 7 years ago.
oracle_textfield_lookup.2.diff (5.4 KB) - added by ian.g.kelly@… 7 years ago.
New version that doesn't break everything -- I should know better than to submit patches when I don't have a test environment available

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by ian.g.kelly@…

Changed 7 years ago by ian.g.kelly@…

New version that doesn't break everything -- I should know better than to submit patches when I don't have a test environment available

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

The patch looks reasonable and I've verified the tests pass on all the MySQL/PostgreSQL/SQLite backends. My vmware setup is hosed at the moment, so I can't test Oracle. Since that's your area anyway, Ian, I'm not too worried.

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5943]) Fixed #5087 -- Fixed support for TextField filtering with Oracle. Thanks, Ian Kelly.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.