Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#5081 closed (wontfix)

Defaults newforms' BooleanField to required=False

Reported by: k0001 <gnuk0001@…> Owned by: adrian
Component: Forms Version: master
Severity: Keywords: booleanfield required
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Defaults newforms' BooleanField to required=False so you don't get validation errors when the checkbox is unchecked.

Attachments (2)

patch.diff​ (418 bytes) - added by k0001 <gnuk0001@…> 7 years ago.
django/newforms/fields.py
patch.2.diff​ (440 bytes) - added by k0001 <gnuk0001@…> 7 years ago.
django/newforms/fields.py

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by k0001 <gnuk0001@…>

django/newforms/fields.py

Changed 7 years ago by k0001 <gnuk0001@…>

django/newforms/fields.py

comment:1 Changed 7 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Why would this be good? All other fields default to required=True. This would be a backwards incompatible change for no gains.

comment:2 Changed 7 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed

Closing this as a wontfix because there's no good reason to make this change.

comment:3 Changed 7 years ago by PhiR

kind of duplicate with #5104

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.