Opened 17 years ago
Closed 17 years ago
#5070 closed (wontfix)
newforms: Default arguments for QuerySetIterator
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Hi,
I think default for the QuerySetIterator would be good::
class QuerySetIterator(object):
def init(self, queryset, empty_label=u"---------", cache_choices=False):
Attachments (1)
Change History (2)
by , 17 years ago
Attachment: | newforms-models-querysetinterator.diff added |
---|
comment:1 by , 17 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I don't see what benefit this brings us, because calling code is supposed to use
ModelChoiceField
, not accessQuerySetIterator
directly. The latter is not documented.And there's a maintainability advantage in only including the default arguments in one place.