Code

Opened 7 years ago

Closed 7 years ago

#5070 closed (wontfix)

newforms: Default arguments for QuerySetIterator

Reported by: Thomas Güttler <hv@…> Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

I think default for the QuerySetIterator would be good::

class QuerySetIterator(object):

def init(self, queryset, empty_label=u"---------", cache_choices=False):

Attachments (1)

newforms-models-querysetinterator.diff​ (591 bytes) - added by Thomas Güttler <hv@…> 7 years ago.

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by Thomas Güttler <hv@…>

comment:1 Changed 7 years ago by adrian

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

I don't see what benefit this brings us, because calling code is supposed to use ModelChoiceField, not access QuerySetIterator directly. The latter is not documented.

And there's a maintainability advantage in only including the default arguments in one place.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.