Code

Opened 7 years ago

Closed 4 years ago

#5048 closed (wontfix)

Allow TypeError exceptions to propagate in templates

Reported by: Jan Rademaker <j.rademaker@…> Owned by: nobody
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This patch fixes a gotcha by counting the number of entries in the traceback. More than 1 entry means the exception happened somewhere in the method.

Attachments (1)

ticket5048.diff (2.7 KB) - added by Jan Rademaker <j.rademaker@…> 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Jan Rademaker <j.rademaker@…>

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 follow-up: Changed 7 years ago by adrian

  • Triage Stage changed from Ready for checkin to Design decision needed

Wait -- we don't want TypeError to be propogated. One of the design goals for the template system is that it shouldn't propogate exceptions.

comment:3 in reply to: ↑ 2 Changed 7 years ago by Jan Rademaker <j.rademaker@…>

Replying to adrian:

Wait -- we don't want TypeError to be propogated. One of the design goals for the template system is that it shouldn't propogate exceptions.

Are you talking about the current sitution or how you think it ought to be? Because right now, any Exception is propogated, except TypeErrors (due to the gotcha) and exceptions with a silent_variable_failure attribute set to True.

comment:4 Changed 4 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

This is backwards incompatible and we really prefer template rendering to never be replaced with a 500 page due to internal crashes time.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.