Opened 8 years ago

Closed 8 years ago

#5032 closed (duplicate)

newforms-admin: missing labels in admin for all translated fields (seen on user change form)

Reported by: Yuri Baburov <burchik@…> Owned by: adrian
Component: contrib.admin Version: newforms-admin
Severity: Keywords: labels, admin, i18n, user
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

You could see this bug on user-editing page: field labels are missing
Problem is here (django/contrib/admin/options.py, lines 87-96):

   def label_tag(self):
        classes = []
        if self.is_checkbox:
            classes.append(u'vCheckboxLabel')
            contents = escape(self.field.label)
        else:
            contents = escape(self.field.label) + u':'  # escape is lazy __proxy__ so + operation fails

Minimal patch looks like this:

        else:
-           contents = escape(self.field.label) + u':'
+           contents = u"%s" % escape(self.field.label) + u':'

Change History (2)

comment:1 Changed 8 years ago by buriy <burchik@…>

  • Component changed from Uncategorized to Admin interface
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from jacob to adrian
  • Patch needs improvement unset

comment:2 Changed 8 years ago by buriy <burchik@…>

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top