Opened 17 years ago

Closed 17 years ago

#5032 closed (duplicate)

newforms-admin: missing labels in admin for all translated fields (seen on user change form)

Reported by: Yuri Baburov <burchik@…> Owned by: Adrian Holovaty
Component: contrib.admin Version: newforms-admin
Severity: Keywords: labels, admin, i18n, user
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

You could see this bug on user-editing page: field labels are missing
Problem is here (django/contrib/admin/options.py, lines 87-96): 

   def label_tag(self):
        classes = []
        if self.is_checkbox:
            classes.append(u'vCheckboxLabel')
            contents = escape(self.field.label)
        else:
            contents = escape(self.field.label) + u':'  # escape is lazy __proxy__ so + operation fails

Minimal patch looks like this:

        else:
-           contents = escape(self.field.label) + u':'
+           contents = u"%s" % escape(self.field.label) + u':'

Change History (2)

comment:1 by buriy <burchik@…>, 17 years ago

Component: Uncategorized → Admin interface
Owner: changed from Jacob to Adrian Holovaty

comment:2 by buriy <burchik@…>, 17 years ago

Resolution: → duplicate
Status: new → closed

Dupe of ​http://code.djangoproject.com/ticket/4958

Note: See TracTickets for help on using tickets.
Back to Top