Opened 8 years ago

Closed 8 years ago

#5013 closed (fixed)

Inaccurate middleware documentation for process_request and process_view

Reported by: tailofthesun@… Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: process_request middleware
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documentation states: "If it returns an HttpResponse object, Django won’t bother calling ANY other middleware or the appropriate view; it’ll return that HttpResponse.", but this is only true for any request, view, or exception middleware method. The remaining response middleware methods are still executed on the returned HttpResponse object.

Attachments (1)

middleware-txt.diff (1.3 KB) - added by Jason Yan <tailofthesun@…> 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from Django Middleware documentation for process_request to Inaccurate middleware documentation for process_request
  • Triage Stage changed from Unreviewed to Accepted

Patches always welcome ;)

Changed 8 years ago by Jason Yan <tailofthesun@…>

comment:2 Changed 8 years ago by Jason Yan <tailofthesun@…>

  • Has patch set
  • Summary changed from Inaccurate middleware documentation for process_request to Inaccurate middleware documentation for process_request and process_view

Added patch -- I noticed the same thing for the process_view documentation.

comment:3 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Triage Stage changed from Accepted to Ready for checkin

Thanks Jason

comment:4 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [6576]) Fixed #5013 -- Corrected the documentation about which how further middleware
processing is done after request or view middleware returns something. Thanks,
Jason Yan.

Note: See TracTickets for help on using tickets.
Back to Top