Opened 17 years ago

Closed 17 years ago

#5013 closed (fixed)

Inaccurate middleware documentation for process_request and process_view

Reported by: tailofthesun@… Owned by: nobody
Component: Documentation Version: dev
Severity: Keywords: process_request middleware
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The documentation states: "If it returns an HttpResponse object, Django won’t bother calling ANY other middleware or the appropriate view; it’ll return that HttpResponse.", but this is only true for any request, view, or exception middleware method. The remaining response middleware methods are still executed on the returned HttpResponse object.

Attachments (1)

middleware-txt.diff​ (1.3 KB ) - added by Jason Yan <tailofthesun@…> 17 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by Chris Beaven, 17 years ago

Needs documentation: set
Summary: Django Middleware documentation for process_request → Inaccurate middleware documentation for process_request
Triage Stage: Unreviewed → Accepted

Patches always welcome ;)

by Jason Yan <tailofthesun@…>, 17 years ago

Attachment: middleware-txt.diff​ added

comment:2 by Jason Yan <tailofthesun@…>, 17 years ago

Has patch: set
Summary: Inaccurate middleware documentation for process_request → Inaccurate middleware documentation for process_request and process_view

Added patch -- I noticed the same thing for the process_view documentation.

comment:3 by Chris Beaven, 17 years ago

Needs documentation: unset
Triage Stage: Accepted → Ready for checkin

Thanks Jason

comment:4 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

(In [6576]) Fixed #5013 -- Corrected the documentation about which how further middleware
processing is done after request or view middleware returns something. Thanks,
Jason Yan.

Note: See TracTickets for help on using tickets.
Back to Top