Opened 17 years ago
Last modified 8 years ago
#4994 closed
Cookies are not sent back for HTTP Not Modified (304) from CommonMiddleware — at Initial Version
| Reported by: | Owned by: | Malcolm Tredinnick | |
|---|---|---|---|
| Component: | HTTP handling | Version: | dev |
| Severity: | Normal | Keywords: | etags |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The CommonMiddleware functionality generates a new HTTP Response object (304) when the E-Tag matches. This new response does not include the Set-Cookie header, which then breaks the login page from django.contrib.auth.views.login.
This also violates the Cookie specification (see http://wp.netscape.com/newsref/std/cookie_spec.html): If a proxy server receives a response which contains a Set-cookie header, it should propagate the Set-cookie header to the client, regardless of whether the response was 304 (Not Modified) or 200 (OK).
The attached patch solves this by moving any set cookies over into the new response object.
Note:
See TracTickets
for help on using tickets.
Patch for 304 and Cookies