Cookies are not sent back for HTTP Not Modified (304) from CommonMiddleware
|Reported by:||colin@…||Owned by:||mtredinnick|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The CommonMiddleware functionality generates a new HTTP Response object (304) when the E-Tag matches. This new response does not include the Set-Cookie header, which then breaks the login page from django.contrib.auth.views.login.
This also violates the Cookie specification (see http://wp.netscape.com/newsref/std/cookie_spec.html): If a proxy server receives a response which contains a Set-cookie header, it should propagate the Set-cookie header to the client, regardless of whether the response was 304 (Not Modified) or 200 (OK).
The attached patch solves this by moving any set cookies over into the new response object.
Change History (3)
Changed 9 years ago by colin@…
comment:1 Changed 9 years ago by Simon G. <dev@…>
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Ready for checkin