Code

Opened 7 years ago

Closed 7 years ago

#4987 closed (fixed)

DecimalField not documented

Reported by: James <james_027@…> Owned by: anonymous
Component: Documentation Version: master
Severity: Keywords: newforms DecimalField
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

under the field type of generating forms for models there is the decimalField by for newforms, but it was not documented on the newforms built in types.

james

Attachments (1)

my_patch.diff (1019 bytes) - added by James <james_027@…> 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from built in DecimalField documentation to DecimalField not documented
  • Triage Stage changed from Unreviewed to Accepted

Thanks James. Perhaps you'd like to attach a patch? :)

comment:2 Changed 7 years ago by James <james_027@…>

  • Owner changed from jacob to anonymous
  • Status changed from new to assigned

Sorry Chris,

I am very new to Django and python programming I might write it wrong.

comment:3 Changed 7 years ago by SmileyChris

Don't let being new stop you writing patches, especially documentation ones.

Assuming you've done a full SVN checkout, just edit the txt file (copying the existing style you find in there) and then produce an svn diff. If you need some more help than that, visit the IRC channel - we're a helpful bunch. Alternatively, don't fret - someone else will probably fix it eventually. :)

comment:4 Changed 7 years ago by James <james_027@…>

  • Has patch set
  • Keywords newforms added
  • Patch needs improvement set

Hi,

This is my patch for the DecimalField of newforms with the help of looking into the source code itself. plus the optional arguments for the IntegerField.

Changed 7 years ago by James <james_027@…>

comment:5 Changed 7 years ago by SmileyChris

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Thanks James, looks good.

comment:6 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5855]) Fixed #4987 -- Added documentation for newforms.DecimalField. Based on a patch from james_027@….

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.