Opened 9 years ago

Closed 9 years ago

#4981 closed (wontfix)

Unchecked BooleanFields raise validation error

Reported by: Caleb <jtxx000@…> Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords: BooleanField
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

BooleanFields should not call "super(BooleanField, self).clean(value)" as that raises a validation error if the field is not included in the data, and unchecked boolean fields aren't included in HTTP POST.

Attachments (1)

patch.diff (361 bytes) - added by Caleb <jtxx000@…> 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Caleb <jtxx000@…>

Attachment: patch.diff added

comment:1 Changed 9 years ago by Chris Beaven

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: invalid
Status: newclosed

It's supposed to. Try required=False

comment:2 Changed 9 years ago by Caleb <jtxx000@…>

Resolution: invalid
Status: closedreopened

What's the point of a checkbox that has to be checked? The docs say that BooleanFields will never raise a validation error.

comment:3 Changed 9 years ago by simonbun <simonbun@…>

One use case off the top of my head: Having users agree to a site's terms of service by checking a box.

comment:4 Changed 9 years ago by Adrian Holovaty

Resolution: wontfix
Status: reopenedclosed

Closing for the reasons pointed out in the comments.

Note: See TracTickets for help on using tickets.
Back to Top