Opened 8 years ago

Closed 8 years ago

#4947 closed (fixed)

large uploaded files cause a slow browser death in debug view

Reported by: eibaan@… Owned by: adrian
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

The Django debug HTML page is great for finding bugs in templates and view functions. However, if you have an error in a view function with a request object that contains a - say - 200MB file object, well, then your browser dies a slow and painful death. At least my trusted Firefox does.

I've created a patch to suppress the file object in the debug view. There might be better ways to do this, I'm a Python beginner. This is the shortest and less intrusive way I could come up with.

Attachments (1)

1.diff (1.3 KB) - added by eibaan@… 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by eibaan@…

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Ready for checkin

Good idea, but patch may need improvement?

comment:2 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5874]) Fixed #4947 -- Avoid displaying uploaded file contents in the debug web page. Based on a patch from eibaan@….

Note: See TracTickets for help on using tickets.
Back to Top