Error in tutorial part 4

[James Bennett]

The sample URL configuration in part 4 of the tutorial uses the syntax of a url call, but without calling url (it passes in a final item to be the name of the URL).

[James Bennett]

Patch which fixes and clarifies the usage

[Chris Beaven]

Are you sure it's an error?

In django.conf.defaults:

def patterns(prefix, *args):
    pattern_list = []
    for t in args:
        if isinstance(t, (list, tuple)):
            t = url(prefix=prefix, *t)

It looks to me like the tuple should work just as well.

[James Bennett]

We had someone on IRC who was following the tutorial code exactly (double-checked by having him paste it) and it was erroring out saying there were too many arguments.

[John Shaffer <jshaffer2112@…>]

Replying to ubernostrum:

We had someone on IRC who was following the tutorial code exactly (double-checked by having him paste it) and it was erroring out saying there were too many arguments.

Are you 100% sure their checkout was up to date?

This code is working fine for us:

urlpatterns += patterns('satchmo.shop.views',
    (r'^cart/(?P<id>\d+)/remove/$', 'cart.remove', {}, 'satchmo_cart_remove'),
)

[Gary Wilson]

Looking at the code, it looks like the tuple should still work, and others have confirmed this. So the real question here is do we want to recommend the use of url() over tuple? I would say yes.

[Malcolm Tredinnick]

(In [5946]) Used the url() function when adding a named URL pattern, mostly as an example of good practice and to introduce the function. Fixed #4908 (although it wasn't a bug).