[patch] Allow whitespace before and after filter separator

[sciyoshi@…]

It always bugged me that I couldn't do {{ variable | filter }} because of the spaces around the pipe. It seems to me that this looks cleaner, although it may have been a design choice not to allow this.

Anyways, here's the patch.

Samuel Cormier-Iijima

[sciyoshi@…]

Patch to allow whitespace around template filter separators

[miguel.filho@…]

I would like to support this change. Right now I'm a django starter and took some time for me to figure out that a simple space was getting my hair off my head. Although the documentation ​http://www.djangoproject.com/documentation/templates/#filters show the example without spaces, seeing the way filters work just give the same feeling of using a pipe in a shell script, with or without spaces.

[Gary Wilson <gary.wilson@…>]

I'm not against allowing spaces, but we probably don't want to allow newlines.

[honeyman]

Just my +1 to this feature (no voting in this ticket engine? would be nice to have). It is slightly inconsistent that Django site logic is written in Python where whitespaces in the code (do not confuse with indentation) do not matter, templates are written mostly in HTML where whitespaces do not alter the rendered output, but the whitespaces inside the filter declarations do matter.

[Johannes Dollinger]

This would be fixed by the refactoring proposed in #7806.

[Malcolm Tredinnick]

Accepted.

[Aymeric Augustin]

This is really a very simple change and it looks reasonable to me.

The current behavior (raising TemplateSyntaxError for spaces around the |) was tested. AFAICT this test exists mostly for completeness and it reasonable to change it if we make the filter syntax less strict.

This may be a sensitive design change. I'll leave the patch in RFC for a few days so that other core devs can get a chance to review or veto it.

[Aymeric Augustin]

Fixed in ddfc7c2530197112fb105b6dd237574bc2fd6b49.