manually named primary key columns not properly quoted

[Antti Kaihola]

If the database column for a primary key is named manually using db_column= and the name contains capital letters, objects can't be saved (at least on PostgreSQL) since the column name is not properly quoted in django.db.models.save().

PostgreSQL or psycopg2 seems to convert unquoted column names to all lower case, and this has to be protected with quotes.

[Antti Kaihola]

adds manual pk column name quoting to the save() method

[Chris Beaven]

Sounds like a valid bug to me, want to add a test case?

[Antti Kaihola]

revised test case for primary key db_column with upper case in the name

[Antti Kaihola]

Hmm, the test I just submitted now passes. Maybe this has already been fixed?

[Antti Kaihola]

updated patch for revision 6137

[Antti Kaihola]

now uses the new qn() function for quoting

[Antti Kaihola]

Ok I'm not sure why the test passes also without my patch. Might be PostgreSQL versions. I'm testing with 8.2 now, and I might have been using 8.0 or 8.1 when I submitted this ticket.

Anyway, looking at the code it seems to me that the qn() is really meant to be used there.

[Malcolm Tredinnick]

All field objects are handed through to the backend and treated consistently now (post queryset-refactor merge), so this doesn't appear to be an issue any longer.