Opened 18 years ago
Closed 18 years ago
#4732 closed (fixed)
newforms-admin branch: utils.py in wrong package
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | admindocs admin interface code cleanup | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
newforms-admin branch:
in the newforms-admin branch, the admin documentation has been taken out of django.contrib.admin and put into django.contrib.admindocs.
the file utils.py ("Misc. utility functions/classes for admin documentation generator.") however still lives in the django.contrib.admin package and is imported from there by the admindocs package.
because this utils.py is only used by admindocs (and not by the admin interface itself) I suggest that it should be moved to admindocs as well and the import statement in views.py in admindocs changed accordingly to reflect this change.
if there are however any plans to use it from within the admin interface as well at some point in the future, then I suggest that the line "Misc. utility functions/classes for admin documentation generator" is changed to somewhat more general.
(In [5570]) newforms-admin: Fixed #4732 -- Moved admin.utils to admindocs.utils. Thanks, _@…