Code

Opened 7 years ago

Closed 7 years ago

#4732 closed (fixed)

newforms-admin branch: utils.py in wrong package

Reported by: _@… Owned by: adrian
Component: contrib.admin Version: master
Severity: Keywords: admindocs admin interface code cleanup
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

newforms-admin branch:

in the newforms-admin branch, the admin documentation has been taken out of django.contrib.admin and put into django.contrib.admindocs.
the file utils.py ("Misc. utility functions/classes for admin documentation generator.") however still lives in the django.contrib.admin package and is imported from there by the admindocs package.

because this utils.py is only used by admindocs (and not by the admin interface itself) I suggest that it should be moved to admindocs as well and the import statement in views.py in admindocs changed accordingly to reflect this change.

if there are however any plans to use it from within the admin interface as well at some point in the future, then I suggest that the line "Misc. utility functions/classes for admin documentation generator" is changed to somewhat more general.

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5570]) newforms-admin: Fixed #4732 -- Moved admin.utils to admindocs.utils. Thanks, _@…

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.