Opened 8 years ago

Closed 7 years ago

#4588 closed (fixed)

newforms-admin: Handle keyword argument `options` of `AdminSite.register`

Reported by: yi.codeplayer at gmail dot com Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-someday
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

I got a simple way to handle the keyword argument options of AdminSite.register:

        if options:
            admin_class = type(admin_class.__name__, (admin_class,), options)

Attachments (1)

handle_options.patch (667 bytes) - added by yi.codeplayer at gmail dot com 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by yi.codeplayer at gmail dot com

comment:1 Changed 7 years ago by jkocherhans

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

I'm mostly ok with this solution. options needs to be validated, but that should probably be the responsibility of ModelAdmin.

comment:2 Changed 7 years ago by brosner

  • Keywords nfa-someday added

This isn't critical to the merge of newforms-admin. #5374 needs to be completed first. Tagging with nfa-someday.

comment:3 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in [8063].

Note: See TracTickets for help on using tickets.
Back to Top