'Delete' action is broken in newforms-admin

[dottedmag@…]

Any 'delete' operation in newadmin-branch (r5457) results in

Request Method:	GET
Request URL:	http://localhost:8001/admin/sites/site/2/delete/
Exception Type:	NameError
Exception Value:	global name '_get_deleted_objects' is not defined
Exception Location:	/home/mag/WORK/django-newforms-admin/django/contrib/admin/options.py in delete_view, line 531

How to reproduce:

1. Create new empty project,
2. Enable django.contrib.admin,
3. Navigate to admin interface,
4. Try to delete any object.

[yi.codeplayer at gmail dot com]

I found a quick way to fix this, just import the name _get_deleted_objects from module django.contrib.admin.views before you use it.

e.t. change the line where this exception occured to:

        from django.contrib.admin.views.main import _get_deleted_objects
        _get_deleted_objects(deleted_objects, perms_needed, request.user, obj, opts, 1)

[dottedmag@…]

Reopen: bug still present in newforms-admin branch.

Workaround is not a justification.

[anonymous]

What ticket number is this a duplicate of? I don't see another ticket for this issue (which is actually a pretty critical bug).

[Simon G. <dev@…>]

Hmmm.. Please don't do anonymous triage.

[Russell Keith-Magee]

(In [5997]) newforms-admin: Fixed #4524 -- Fixed object deletion in the admin interface. Moved get_deleted_objects to a util package rather than importing from the existing location (where it is no longer required). This was to resolve a circular import problem.

[anonymous]

I'm still getting this with newforms-admin 0.97-newforms-admin-SVN-6454

[Karen Tracey <kmtracey@…>]

Works for me with: Django version 0.97-newforms-admin-SVN-6522

I tried both a simple delete and cascading one, both worked fine.

[ariddell <allen.riddell@…>]

Still getting it in 6525

This error seems pretty clear:

/usr/lib/python2.5/site-packages/django/contrib/admin/options.py in delete_view

line 659 reads:

from django.contrib.admin.views.main import _get_deleted_objects

there is no function _get_deleted_objects in django.contrib.admin.views.main

[ariddell <allen.riddell@…>]

nevermind, I had modified my copy of options.py per the instructions in the first comment. sorry!