Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4497 closed (wontfix)

Bug if form_url is empty (i.e. creating new user), and TEMPLATE_STRING_IF_INVALID is set

Reported by: buriy <burchik@…> Owned by: adrian
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by mtredinnick)

Index: D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html
===================================================================
--- D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html	(revision 5418)
+++ D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html	(working copy)
@@ -23,7 +23,7 @@
   </ul>
 {% endif %}{% endif %}
 {% endblock %}
-<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}action="{{ form_url }}" method="post" id="{{ opts.module_name }}_form">{% block form_top %}{% endblock %}
+<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}{% if form_url %}action="{{ form_url }}" {% endif %}method="post" id="{{ opts.module_name }}_form">{% block form_top %}{% endblock %}
 <div>
 {% if is_popup %}<input type="hidden" name="_popup" value="1" />{% endif %}
 {% if opts.admin.save_on_top %}{% submit_row %}{% endif %}

Attachments (1)

4497.patch (1.0 KB) - added by buriy <burchik@…> 7 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by buriy <burchik@…>

Patch

comment:1 Changed 7 years ago by buriy <burchik@…>

  • Component changed from Uncategorized to Admin interface
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from jacob to adrian
  • Patch needs improvement unset

Please fix ticket description.

comment:2 Changed 7 years ago by mtredinnick

  • Description modified (diff)
  • Resolution set to wontfix
  • Status changed from new to closed

(fixed ticket description)

The admin interface depends on TEMPLATE_STRING_IF_INVALID being empty. There is another ticket open to remove that dependence, but for now it exists. Fixing it piecemeal is not going to be very effective.

comment:3 Changed 7 years ago by buriy <burchik@…>

Thanks for your hard work on other issues, but situation with TEMPLATE_STRING_IF_INVALID and admin interface was not changed during last year, even though there were only few such small errors left in admin interface. And you are talking about effectiveness :) IMHO, dividing tasks into small and easy parts is the greatest way to solve complex problems. Ok, I will copy patch to that first ticket (which one is first, by the way?).

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.