Bug if form_url is empty (i.e. creating new user), and TEMPLATE_STRING_IF_INVALID is set

[buriy <burchik@…>]

Index: D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html
===================================================================
--- D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html	(revision 5418)
+++ D:/program/Python24/Lib/site-packages/django-svn/django/contrib/admin/templates/admin/change_form.html	(working copy)
@@ -23,7 +23,7 @@
   </ul>
 {% endif %}{% endif %}
 {% endblock %}
-<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}action="{{ form_url }}" method="post" id="{{ opts.module_name }}_form">{% block form_top %}{% endblock %}
+<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}{% if form_url %}action="{{ form_url }}" {% endif %}method="post" id="{{ opts.module_name }}_form">{% block form_top %}{% endblock %}
 <div>
 {% if is_popup %}<input type="hidden" name="_popup" value="1" />{% endif %}
 {% if opts.admin.save_on_top %}{% submit_row %}{% endif %}

[buriy <burchik@…>]

Patch

[buriy <burchik@…>]

Please fix ticket description.

[Malcolm Tredinnick]

(fixed ticket description)

The admin interface depends on TEMPLATE_STRING_IF_INVALID being empty. There is another ticket open to remove that dependence, but for now it exists. Fixing it piecemeal is not going to be very effective.

[buriy <burchik@…>]

Thanks for your hard work on other issues, but situation with TEMPLATE_STRING_IF_INVALID and admin interface was not changed during last year, even though there were only few such small errors left in admin interface. And you are talking about effectiveness :) IMHO, dividing tasks into small and easy parts is the greatest way to solve complex problems. Ok, I will copy patch to that first ticket (which one is first, by the way?).