Code

Opened 7 years ago

Closed 7 years ago

#4475 closed (fixed)

typo in serializers_regress tests means that fieldsTest is run twice and streamTest not at all.

Reported by: ian.g.kelly@… Owned by: adrian
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The serializers_regress test runs fieldsTest twice and streamTest not at all.

Attachments (2)

streamTest.diff (713 bytes) - added by ian.g.kelly@… 7 years ago.
streamTest.2.diff (936 bytes) - added by ian.g.kelly@… 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by ian.g.kelly@…

Changed 7 years ago by ian.g.kelly@…

comment:1 Changed 7 years ago by ian.g.kelly@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Added the second diff after realizing that there is a second problem that the first diff doesn't address.

The python serializer now fails this test, but that appears to be a legitimate failure and thus outside the scope of this patch.

comment:2 Changed 7 years ago by Simon G. <dev@…>

  • Summary changed from Patch: fix typo in serializers_regress tests to typo in serializers_regress tests means that fieldsTest is run twice and streamTest not at all.
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5453]) Fixed #4475 -- Fixed a problem that was preventing streaming tests for the
serializers from ever being run. Based on a patch from ian.g.kelly@….

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.