Opened 9 years ago

Closed 9 years ago

#4462 closed (fixed)

minor ForNode.render reversed optimization

Reported by: (removed) Owned by: Adrian Holovaty
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

short version, nestled snuggly in django.template.defaulttags.ForNode.render is a homebrewed native reverse implementation; aside from it using range when it should be using xrange, this is fine for <py2.4; for >=py2.4 however, the builtin reversed should be used (fair bit faster among other things).

So... attached is a patch doing just that; for folks using >=2.4, it's a linear 10x boost (mass index lookups kill kittens when in combination with native py vs cpy speeds), so... worth adding.

Attachments (1)

use-builtin-reverse-if-available.patch​ (1.0 KB) - added by (removed) 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by (removed)

Attachment: use-builtin-reverse-if-available.patch​ added

comment:1 Changed 9 years ago by Malcolm Tredinnick

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: Unreviewed → Ready for checkin

Indeed! Looks good.

comment:2 Changed 9 years ago by Malcolm Tredinnick

Resolution: → fixed
Status: new → closed

(In [5454]) Fixed #4462 -- Use builtin reversed() function when available (in "for" tag).
Thanks, Brian Harring.

Note: See TracTickets for help on using tickets.
Back to Top