typo in django/db/models/fields/__init__.py

[Krzysztof Sitarski <sit0@…>]

in line 500 (DateTime.get_db_prep_save) there should be:

value = time.strptime(value, '%Y-%m-%d')

instead of:

value = value.strftime('%Y-%m-%d')

[Adrian Holovaty]

Are you sure this is a typo? It's been working thus far...

Could you explain what the problem is?

[patrys@…]

Exception Type:  	AttributeError
Exception Value: 	'str' object has no attribute 'strftime'

[patrys@…]

BTW, I believe this was caused by using raw request.POST instead of Form.cleaned_data. This is not my code and I just fixed a similar "error" that was caused by using wrong data source

[Malcolm Tredinnick]

We are still no closer to establishing if this is a problem in Django or not. What do you have to do to replicate this problem. Merely posting the exception does not give steps to reproducing.

As Adrian mentioned, there is already a lot of code using that code path, so it must be something unusual that is being done to trigger this. A small example that demonstrates the problem would be ideal here.

[patrys@…]

Please notice that I am not the one who filed the bug. I just saw a production code hitting the same line that the patch changes and after going through the code I found out the reason was a call to a model constructor that used request.POST instead of form.cleaned_data

[Simon G. <dev@…>]

Marked as invalid unless someone can please give some more information?