Opened 9 years ago

Closed 9 years ago

#4416 closed (wontfix)

HttpResponseServiceUnavailable patch

Reported by: Guilherme Gondim Owned by: Adrian Holovaty
Component: Core (Other) Version: master
Severity: Keywords:
Cc: semente@… Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I need put my site in maintenance, but Django don't have a HttpResponse for http status code 503[1].

In attachment, a simple patch.

Thanks!

  1. http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.5.4

Attachments (1)

httpresponse503.patch (531 bytes) - added by Guilherme Gondim 9 years ago.
HttpResponse for status code 503 patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Guilherme Gondim

Attachment: httpresponse503.patch added

HttpResponse for status code 503 patch

comment:1 Changed 9 years ago by Malcolm Tredinnick

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

It's not clear that creating an extra class for every HTTP response code is a good idea. It's a lot of classes and most of them are just changing one number. Maybe HttpReponse can take a status code param or something.

We need to think about this some more.

comment:2 Changed 9 years ago by Guilherme M. Gondim (semente) <semente@…>

Cc: semente@… added

Add my email in Cc.

comment:3 Changed 9 years ago by Jacob

Resolution: wontfix
Status: newclosed

I agree with Malcolm; this isn't the right way to handle this.

Note: See TracTickets for help on using tickets.
Back to Top