Opened 10 years ago

Closed 10 years ago

#4403 closed (fixed)

[unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors

Reported by: hidded <me@…> Owned by: Malcolm Tredinnick
Component: Forms Version: other branch
Severity: Keywords: unicode
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Subj. Use form.as_p() if you want to see this bug.

Attachments (1)

unicode-newforms-path.diff (794 bytes) - added by hidded <me@…> 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by hidded <me@…>

Attachment: unicode-newforms-path.diff added

comment:1 Changed 10 years ago by Malcolm Tredinnick

Thanks for the report.

That patch isn't the right solution because the force_unicode() call is needed for python 2.3. It does highlight that there's a bug further down when I don't call force_unicode() on bf_errors in the normal processing path, though.

The proper fix is to add a __unicode__ method to ErrorList, I suspect. I'll fix that shortly.

comment:2 Changed 10 years ago by Malcolm Tredinnick

Owner: changed from Adrian Holovaty to Malcolm Tredinnick
Summary: unicode: Form._html_output() crashed if errors_on_separate_row is True and form has errors[unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors

comment:3 Changed 10 years ago by hidded <me@…>

Keywords: unicode-branch added

comment:4 Changed 10 years ago by Malcolm Tredinnick

Keywords: unicode-branch removed

Removing the unicode-branch keyword because I'm using that for bugs on trunk that are fixed on the branch. We know this ticket is for the unicode branch because of the [unicode] prefix in the summary.

comment:5 Changed 10 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5375]) Fixed #4403 -- Stopped pushing form error messages (which are unicode strings)
through a str method.

Note: See TracTickets for help on using tickets.
Back to Top