Code

Opened 7 years ago

Closed 7 years ago

#4403 closed (fixed)

[unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors

Reported by: hidded <me@…> Owned by: mtredinnick
Component: Forms Version: other branch
Severity: Keywords: unicode
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Subj. Use form.as_p() if you want to see this bug.

Attachments (1)

unicode-newforms-path.diff (794 bytes) - added by hidded <me@…> 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by hidded <me@…>

comment:1 Changed 7 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Thanks for the report.

That patch isn't the right solution because the force_unicode() call is needed for python 2.3. It does highlight that there's a bug further down when I don't call force_unicode() on bf_errors in the normal processing path, though.

The proper fix is to add a __unicode__ method to ErrorList, I suspect. I'll fix that shortly.

comment:2 Changed 7 years ago by mtredinnick

  • Owner changed from adrian to mtredinnick
  • Summary changed from unicode: Form._html_output() crashed if errors_on_separate_row is True and form has errors to [unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors

comment:3 Changed 7 years ago by hidded <me@…>

  • Keywords unicode-branch added

comment:4 Changed 7 years ago by mtredinnick

  • Keywords unicode-branch removed

Removing the unicode-branch keyword because I'm using that for bugs on trunk that are fixed on the branch. We know this ticket is for the unicode branch because of the [unicode] prefix in the summary.

comment:5 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5375]) Fixed #4403 -- Stopped pushing form error messages (which are unicode strings)
through a str method.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.