Opened 17 years ago
Closed 9 years ago
#4363 closed New feature (fixed)
Formpreview doesn't support newform's dynamic initial values
| Reported by: | Indy | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.formtools | Version: | dev |
| Severity: | Normal | Keywords: | preview |
| Cc: | sciyoshi@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The formpreview has no hook for dynamic initial field values. The attached patch provides this hook.
Attachments (1)
Change History (9)
Changed 17 years ago by
| Attachment: | preview.diff added |
|---|
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:3 Changed 16 years ago by
| Cc: | sciyoshi@… added |
|---|
comment:4 Changed 13 years ago by
| Needs tests: | set |
|---|---|
| Patch needs improvement: | set |
| Triage Stage: | Design decision needed → Accepted |
Patch is out of date, but the approach seems fine. Needs tests as well.
comment:5 Changed 13 years ago by
| Severity: | → Normal |
|---|---|
| Type: | → New feature |
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
formtools has been extracted into its own repository (https://github.com/django/django-formtools/). Because of this, the issue tracking for this package has been moved to GitHub issues. I'm going to close this ticket, but I've created a GitHub issue to replace it where the conversation can continue: https://github.com/django/django-formtools/issues/24. Thanks!
Note: See
TracTickets for help on using
tickets.
Why not make this a bit more generic? If you look at #3218 (shameless promotion), it has this fixed - it can cope with initial data (via
self.initial), custom rendering mechanisms etc.Wouldn't it make more sense to build a common super class for
FormPreviewandWizard? There is some shared code in already and since both classes are used in a very similar manner, it would make sense to refactor the common parts out. I will be happy to do the work.