Code

Opened 7 years ago

Closed 7 years ago

#4348 closed (fixed)

Google sitemap ping update

Reported by: marijn <marijn@…> Owned by: adrian
Component: contrib.syndication Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Google's documentation on pinging changes in sitemaps ( http://www.google.com/support/webmasters/bin/answer.py?answer=34609 ) is different from the current Django implementation. The Patch provides updates to comply with preferred way of pinging.

Attachments (1)

google_sitemap_ping.diff (793 bytes) - added by marijn <marijn@…> 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by marijn <marijn@…>

comment:1 Changed 7 years ago by Marc Fargas <telenieko@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

The patch does not require any docs or tests from my POV.
Just one comment, it assumes http:// maybe there should be some way to say "Hey my site is only https://" but that would be another ticket ;)

marking as "Ready for checkin" as it seems complete.

comment:2 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5300]) Fixed #4348 -- Updated Google sitemap ping code. Thanks, marijn

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.