Opened 10 years ago

Closed 10 years ago

#4323 closed (fixed)

[patch] Display author name without author email for RSS 2.0

Reported by: wangchun <yaohua2000@…> Owned by: Adrian Holovaty
Component: contrib.syndication Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the current implementation, the RSS 2.0 generator does not write author name if the author has not an email. The patch fixes this problem.

Attachments (1)

4323.diff (1.1 KB) - added by wangchun <yaohua2000@…> 10 years ago.
patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by wangchun <yaohua2000@…>

Attachment: 4323.diff added

patch

comment:1 Changed 10 years ago by Chris Beaven

Triage Stage: UnreviewedDesign decision needed

Thanks for the patch, wangchun.

It looks valid but I'm not an expert in this area, so I'll forward to a design decision to make sure this is the way it should be done.

comment:2 Changed 10 years ago by Malcolm Tredinnick

Needs documentation: set
Triage Stage: Design decision neededAccepted

I thought I'd already triaged this -- apparently it was another one I just decided to do in my head and didn't get as far as the web browser. :-(

This change is fine. It's the accepted way to do this for RSS 2.0.

Needs a documentation update before it can go in (to syndication.txt).

comment:3 in reply to:  2 Changed 10 years ago by wangchun <yaohua2000@…>

Needs documentation: unset
Triage Stage: AcceptedReady for checkin

Replying to mtredinnick:

Needs a documentation update before it can go in (to syndication.txt).

But I suppose this patch introduces no documentation update, since it just added a missing feature for RSS 2.0. The Atom 1.0 generator had already have such support.

comment:4 Changed 10 years ago by Malcolm Tredinnick

Hmm... you're right. Our syndication documentation is a bit lame in that it doesn't mention which features are required/implemented for which feed types in all cases.

comment:5 Changed 10 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5357]) Fixed #4323 -- Added the ability to display author names without email
addresses to RSS 2.0 feeds.

Note: See TracTickets for help on using tickets.
Back to Top