Code

Opened 7 years ago

Closed 7 years ago

#4323 closed (fixed)

[patch] Display author name without author email for RSS 2.0

Reported by: wangchun <yaohua2000@…> Owned by: adrian
Component: contrib.syndication Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the current implementation, the RSS 2.0 generator does not write author name if the author has not an email. The patch fixes this problem.

Attachments (1)

4323.diff (1.1 KB) - added by wangchun <yaohua2000@…> 7 years ago.
patch

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by wangchun <yaohua2000@…>

patch

comment:1 Changed 7 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

Thanks for the patch, wangchun.

It looks valid but I'm not an expert in this area, so I'll forward to a design decision to make sure this is the way it should be done.

comment:2 follow-up: Changed 7 years ago by mtredinnick

  • Needs documentation set
  • Triage Stage changed from Design decision needed to Accepted

I thought I'd already triaged this -- apparently it was another one I just decided to do in my head and didn't get as far as the web browser. :-(

This change is fine. It's the accepted way to do this for RSS 2.0.

Needs a documentation update before it can go in (to syndication.txt).

comment:3 in reply to: ↑ 2 Changed 7 years ago by wangchun <yaohua2000@…>

  • Needs documentation unset
  • Triage Stage changed from Accepted to Ready for checkin

Replying to mtredinnick:

Needs a documentation update before it can go in (to syndication.txt).

But I suppose this patch introduces no documentation update, since it just added a missing feature for RSS 2.0. The Atom 1.0 generator had already have such support.

comment:4 Changed 7 years ago by mtredinnick

Hmm... you're right. Our syndication documentation is a bit lame in that it doesn't mention which features are required/implemented for which feed types in all cases.

comment:5 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5357]) Fixed #4323 -- Added the ability to display author names without email
addresses to RSS 2.0 feeds.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.