Opened 8 years ago

Closed 8 years ago

#4318 closed (fixed)

unused imports in newforms modules

Reported by: Gary Wilson <gary.wilson@…> Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The import sections also don't adhere to our coding style.

Attachments (1)

4318.diff (4.4 KB) - added by Gary Wilson <gary.wilson@…> 8 years ago.
cleaned up imports

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Gary Wilson <gary.wilson@…>

cleaned up imports

comment:1 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

fixes:

  • Reordered imports with standard library imports first and sections separated by a line break. I added a line break between django imports and the relative imports for visual distinction.
  • Fixed long lines.
  • Moved __all__ to come after imports.
  • Removed unused imports.

comment:2 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • Has patch set
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5263]) Fixed #4318 -- Fixed unused imports and other various style tweaks in newforms. Thanks, Gary Wilson

Note: See TracTickets for help on using tickets.
Back to Top