Opened 17 years ago
Closed 17 years ago
#4316 closed (fixed)
remove use of lambda for flatatt function
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Attachments (1)
Change History (5)
by , 17 years ago
Attachment: | flatatt.diff added |
---|
comment:1 by , 17 years ago
Has patch: | set |
---|---|
Triage Stage: | Unreviewed → Ready for checkin |
comment:2 by , 17 years ago
It's a bit of a personal preference whether this is more readable or not. In some ways it now looks like it's quite complicated by taking up more space, when it's really just a one-line function. They even compile to exactly the same bytecode. So this is a line-ball.
Tests should definitely go in, though.
comment:4 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
more readable, yes? Added a couple tests too.