Opened 8 years ago

Closed 8 years ago

#4297 closed (fixed)

make BaseForm's __errors attribute non-private

Reported by: Gary Wilson <gary.wilson@…> Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Having __errors as a private attribute makes building subclasses that want to access or manipulate errors harder than it could be since the __errors attribute is "hidden away" in the parent class. To have access to the subclass's __errors attribute you have to override any parent class method that sets the __errors attribute (so that it is stored as a private attribute of the subclass instead of a private attribute of the parent class.

Attachments (1)

4297.diff (1.8 KB) - added by Gary Wilson <gary.wilson@…> 8 years ago.
changed __errors to _errors

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Gary Wilson <gary.wilson@…>

changed __errors to _errors

comment:1 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5347]) Fixed #4297 -- Made form errors available to sub-classes. Thanks, Gary Wilson.

Note: See TracTickets for help on using tickets.
Back to Top