Opened 18 years ago
Closed 17 years ago
#4290 closed (fixed)
misleading comment about trailing slash on MEDIA_URL in settings.py
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Core (Management commands) | Version: | dev |
Severity: | Keywords: | MEDIA_URL django-admin | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently it says:
# URL that handles the media served from MEDIA_ROOT. # Example: "http://media.lawrence.com"
Which is an error, since the MEDIA_URL has to end with a "/" as far as I know.
So I add this little patch that corrects this comment.
It's no code change, but a real pitfall for new users coming to django.
Attachments (1)
Change History (3)
by , 18 years ago
Attachment: | conf_project_template_settings.py.diff added |
---|
comment:1 by , 18 years ago
Summary: | misleading comment in conf/project_template/settings.py → misleading comment about trailing slash on MEDIA_URL in settings.py |
---|---|
Triage Stage: | Unreviewed → Ready for checkin |
This is only true if the url has a path component, but this is the type of thing that can confuse people. It may be worth removing the / for http://media.lawrence.com but keeping the other example, but I'll leave that up to the checker-in.
comment:2 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
patch for the documentation-comment