Code

Opened 9 years ago

Closed 9 years ago

#429 closed enhancement (fixed)

Proposed minor cleanup of utils/html.py

Reported by: pb@… Owned by: adrian
Component: Core (Other) Version:
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The patch attached below makes minor changes to the variable names used for regular expression objects in utils/html.py, for the sake of internal consistency and consistency with other Django modules.

The variable names in the patch are lowercase (as they are in core/validators.py and core/defaultfilters.py) and they all now end with "_re" (this was not consistent in html.py, but seems fairly consistent elsewhere).

No other modules in the Django distribution appear to reference these names directly.

I also edited the module docstring -- it contained what I think was the last reference to World Online in the codebase, and contained three variants of the word "use," which I thought excessive for a single sentence fragment :)

Attachments (1)

html.py.2.patch (4.5 KB) - added by pb@… 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by pb@…

comment:1 Changed 9 years ago by pb@…

Disregard html.py.patch -- use html.py.2.patch instead. (Trac server wouldn't let me replace the first attachment, but admins should feel free to delete it.)

comment:2 Changed 9 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [611].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.