Opened 19 years ago

Closed 19 years ago

#429 closed enhancement (fixed)

Proposed minor cleanup of utils/html.py

Reported by: pb@… Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The patch attached below makes minor changes to the variable names used for regular expression objects in utils/html.py, for the sake of internal consistency and consistency with other Django modules.

The variable names in the patch are lowercase (as they are in core/validators.py and core/defaultfilters.py) and they all now end with "_re" (this was not consistent in html.py, but seems fairly consistent elsewhere).

No other modules in the Django distribution appear to reference these names directly.

I also edited the module docstring -- it contained what I think was the last reference to World Online in the codebase, and contained three variants of the word "use," which I thought excessive for a single sentence fragment :)

Attachments (1)

html.py.2.patch (4.5 KB ) - added by pb@… 19 years ago.

Download all attachments as: .zip

Change History (3)

by pb@…, 19 years ago

Attachment: html.py.2.patch added

comment:1 by pb@…, 19 years ago

Disregard html.py.patch -- use html.py.2.patch instead. (Trac server wouldn't let me replace the first attachment, but admins should feel free to delete it.)

comment:2 by Adrian Holovaty, 19 years ago

Resolution: fixed
Status: newclosed

Fixed in [611].

Note: See TracTickets for help on using tickets.
Back to Top