Code

Opened 7 years ago

Closed 7 years ago

#4200 closed (fixed)

get_admin_log template tag returns nothing if no user is specified

Reported by: Bryan Chow <bryan at verdjn dot com> Owned by: adrian
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The get_admin_log template tag defined in django.contrib.admin returns nothing if no user is specified. Although there are currently no cases in admin where this tag is called without specifying a user, the usage comments for the template tag indicate that this should be supported, and this would be useful for other apps using the tag.

Patch is attached.

Attachments (1)

get_admin_log.patch​ (809 bytes) - added by anonymous 7 years ago.
Fix for get_admin_log template tag

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by anonymous

Fix for get_admin_log template tag

comment:1 Changed 7 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Thanks Bryan

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5170]) Fixed #4200 -- Made get_admin_log template tag behave according to its
docstring (user specifier is optional). Thanks, Bryan Chow.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.