Code

Opened 7 years ago

Closed 7 years ago

#4176 closed (fixed)

DebugLexer breaks token source (breaking django exceptions)

Reported by: SmileyChris Owned by: adrian
Component: Template system Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.views.debug.get_template_exception_info expects the token source to be (origin, (start, end)):

origin, (start, end) = exc_value.source

Malcolm's recent change in [5104] changed this to just (start, end) which is breaking Django's pretty exception view.

Patch attached.

Attachments (1)

broken_token_source.patch (653 bytes) - added by SmileyChris 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by SmileyChris

comment:1 Changed 7 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

This is a rather urgent patch. The committer should be very careful to check my code, but I'm pretty sure my logic is sound.

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5116]) Fixed #4176 -- Fixed unintended change introduced in [5104]. Thanks,
SmileyChris.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.