Code

Opened 7 years ago

Closed 7 years ago

#4125 closed (fixed)

datastructures EasyQuerySet (+ small fixes)

Reported by: SmileyChris Owned by: adrian
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Here's a working implementation to make the calendar views work properly.

It also fixes a couple of small annoyances I had:

  • provide base_site.html to override
  • show "X objects for field" when on an object list page

Attachments (5)

databrowse_fixes.patch (15.2 KB) - added by SmileyChris 7 years ago.
databrowse_fixes.2.patch (14.8 KB) - added by SmileyChris 7 years ago.
Oops - base.html, not .htm
databrowse_fixes.3.patch (14.8 KB) - added by SmileyChris 7 years ago.
*sigh*, one more try
databrowse_fixes.4.patch (14.2 KB) - added by SmileyChris 7 years ago.
Fixing that template glitch
databrowse_fixes.5.patch (14.6 KB) - added by SmileyChris 7 years ago.
"x objects" on the main object list page too

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by SmileyChris

Changed 7 years ago by SmileyChris

Oops - base.html, not .htm

Changed 7 years ago by SmileyChris

*sigh*, one more try

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

These both sound like useful changes.

comment:2 Changed 7 years ago by mtredinnick

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

This patch can't be correct: the changes to base.html defines two blocks called "title".

Changed 7 years ago by SmileyChris

Fixing that template glitch

comment:3 Changed 7 years ago by SmileyChris

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Changed 7 years ago by SmileyChris

"x objects" on the main object list page too

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5947]) Fixed #4125 -- Added some small fixes to contrib.databrowse: fixed calendar views, added a summary of the number of objects in each list, and added a template entry point for the customisation enthusiasts. Nice work, SmileyChris.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.